>>109105793
Tadost

>>109105793
>https://github.com/lobsters/lobsters/pull/1218

<% if @user&.is_admin && @user&.show_email? %>

vs

  <% if @user.is_admin? || @user.show_email? %>

Seems different to me.

That said:

https://github.com/lobsters/lobsters/commit/7037494eb85003603ecd87fb00bde994e111f103

>The fix is literally adding an extra "&" for the "show_user" and cleaning up that call to be more appropriate.

I don't think she did anything overly wrong (besides the obvious failure in security NOW) since that push was available for 3 years (nearly) and nobody else fixed it until now.

Ironically enough, it's the *PERSON THAT PUSHED IT* that is the one that fixed it. So ultimately it's on them for failing to see this the first time.

>>109105793
is she here to inspire women to insert severe information disclosure bugs into the codebase?

>>109105793
kek'd

>>109107694
what seems different? she wrote both those snippets, the second was eventually merged after the PR comment.
the mistake was using @user.show_email instead of @showing_user.show_email.
yes, that is "overly wrong", you retard.

File: Screenshot_20260622_15475(...).jpg (321 KB, 909x1640)

321 KB JPG

to be fair, a guy told her to do it

>>109110721
There was a bug there to begin with, but the initial bug wouldn't be this catastrophic

File: 1775160064141604.png (872 KB, 1200x675)

872 KB PNG

>>109105793

>>109107694
Ruby is such a shit language it's wild.

I thank god I can work on go and typescript

File: 1763382251179.png (155 KB, 1502x823)

155 KB PNG

>>109107694
When i had to implement an account system with different types of registration, including third party and implemented an OIDC identity provider from scratch according to specs, i went through all code i wrote multiple times, tested every option, slept on it, looked at it again the next day, slept on it another day, and only then dared to commit changes.

Meanwhile pic related is not considered "overly wrong"?
It is a careless mistake that would be an understandable non-issue when it's some UI code that touches nothing important.
It is an offense by negligence when it's about user data.
You should treat different parts of your code different.

>>109111006
Do people even write registration code anymore? Every forum says to use <library>, for example for nodejs it is passport I think.
I still roll my own because there has been so many supply chain attacks lately and claude has been getting good at finding vulns so I prefer to use as little of standard foss libraries as possible

>>109110783
lol

>>109110783
>How could you tell I'm somali?

>>109111772
where is the cats