How do you deal with over zealous colleagues who like to comment on your PRs until you bleed to death? Pic unrelated.
>>108596640give me a few examples pic unrelated
>>108596694lots of comments are self-identified as "nits", then some comments are like "hey, so we use A and B for C", but there's no call to action or anything. It's all kind of vague like "I found something, but I'm not saying something is wrong but there might be"
>>108596640Better communication. Nerds deny this but no one's the main character even you, everything grand we have built as a species has been collaborative
>>108596787I'm not trying to be the main character, I'm saying it's just a job. I've been doing this long enough to not care, because I've got personal autismo projects where I care (but don't actually bother others). You can't just tell them "hey, let's treat it like a fucking job", it's on corpo slack after all.
>nitsGenerally these should come with an approval, and then you can fix the nits and unilaterally merge. Also if, say, it's urgent to merge the PR e.g. for a customer release or to unblock another feature, and the nits would take more than 5 minutes to go through and quickfix, you should be able to say "I'll fix it in a follow-up PR" (and then do so).>we use A and B for CUse your judgement and if it'd genuinely be better to switch to using A and B here, then do so. If not, reply with your arguments to the contrary. If need be ping the guy on slack and discuss this, so you can come to an agreement (either he has a real case for why it'd be better and you go ahead and change it, or you're correct and convince him and he withdraws his comment).Also similarly under time pressure OR if this "improvement" would increase the scope of the PR, then definitely leave it for a follow-up. For example, if they say "hey, we use A for B, and here you're doing B2 which is similar, we should just extend A to add the feature to do B2 as well and reuse it here!" and it's not a completely trivial change, then merge your main PR first and then make a "refactor A and simplify B2 usage" PR immediately afterwards.Small, self-contained PRs are much better than massive monoliths touching every part of the codebase. Do one thing, and do it well.Some things may not even be in scope for your task in general, e.g. "Actually we should refactor A so it's faster and more efficient for both your usecase and these other ones!" In which case you make an issue/ticket for "refactor A to be better" and leave it for later.t. working on a team right now that also makes lots of comments like these and it works really well if you just prioritise correctly, defer unrelated work and use your judgement
Change job.
@Claude address the comments, make no mistakes
>>108596835This sounds alright in theory. In practice I feel like everyone eventually gets annoyed of too many comments. I just want people to have like some comment budget and if you spent it, you're not allowed to comment. Maybe force 4chan captcha on them too, that'll teach them.
>>108596849yeah, but then this would be very disrespectful, I don't really copy paste LLMs when talking to people and dislike when they do it to me.
>>108596871>if i do it it's disrespectful>other people do it me though>copy/pasteoh you're getting fired first huh
>>108596849Kill yourself.
>>108596894aren't u niggas being genocided or smth bruhshouldn't u be a camp? do they got internet in joberg-auschwitz?
>>108596787>t.
>>108596892no, I don't think they do it to me, the few times they did I sort of pretended I didn't notice, but thankfully no one is that hopeless on the team to keep doing it constantly, not the devs anyway. And I don't think I give people enough reason to throw LLM copypasta at me.
>>108596906My name comes from the fact I'm an ethnic Afrikaner and I used to live in _Bloemfontein_, yes. Family emigrated to the US when Mandela took up arms.
>>108596933go back to africa, nigga.
>>108596640Always ask for them to suggest a change, the PR will get stuck in review because they never respond. When management starts asking questions show them the PR and lack of responses to your questions.
It's the worst part of modern development. I would have never gotten the degree or gone into this biz if I knew it was going to be an endless game of juggling PRs for all eternity and dealing with disagreeable asshats.
>>108597054Also it's hilarious how everyone has rushed to clumsily adopt "AGILE" (their flavor of it), that manages to retain all of the most annoying and useless bits while ignoring the ones that actually benefit devs in quality of lifeYes we will get the endless useless meetings, ceremonies, fake urgent sprint grind, tickets, etc. but>don't overload developer context (only one in progress task at a time)>fibonnacci story estimates, always round up to account for the unknownsno no no no that's terrible we WILL load you up with tickets and we WILL force you to balance an eternal load of PRs that seemingly never hit the finish line
>>108597054>>108597067>PR review with autistic, arrogant retards>Corporate OOP Shitcode with 80 nested classes just to access a database table>"Agile" aka sprint death marches>SOC 2 requiring you to patch all security vulnerabilities (there are 18 new ones each day btw) with no time to patch them in whatever layer of NPM Hell the retarded founder created (he cashed out already)>Actually mediocre pay for the level of stress but everyone thinks you make $300k/year because of FAANGgots>Cucked coworkers who think Marvel movies and playing with the latest JS framework is "fun">Cucked coworkers who have given up all free will to Codex/Claude and are lauded for "efficiency" while you clean up their messes>Stay at a job longer than 2 years and you all get outsourced to Bangalore anywayYeah, this career sucks ass.
