Do you get offended when smarter people than you write comments on your PRs? I've noticed that the smarter a person is, the less they get offended.
>>108685686What's a PRs?
>>108685692Pull requests
>>108685692Personal Records
>>108685692public relations
>>108685692Punjab Regiment
I only get offended by dumb people reviews. Like one time I had dude complain about my JavaScript code that using switch statements is bad practice and according to clean code I should define classes for each case and follow recommended OOP design patterns. He also couldn't understand tagged string templates(sql-template-strings) and announced my code is riddled with SQL injections.Things like that only happen at work though. I never had a bad code review in a FOSS project.
>>108685692penal realingment
Proverbs 12:11Whoever loves discipline loves knowledge,but whoever hates correction is stupid.
>>108685686I get offended when dumb people write totally inane things like pointing out line spacing instead of addressing the real issues I deliberately left in the code to see if they actually were reviewing it properly
>>108685726Design patterns is a meme. If you write bad code, nothing will save you.
Why are they called pull requests when calling them merge requests makes more sense?
>>108685686>Do you get offended when smarter people than you write comments on your PRs?Yea, they are a bunch of motherfuckers. I hate them so much so much so much aaaaa>I've noticed that the smarter a person is, the less they get offended.Haha, I was just kidding. They help me to improve so I love them
>>108685686There are no people smarter than me, so it wouldn't come up.
I don't get offended, I just don't believe in code reviews, especially now in the age of LLMs, because you either write your code, then ask an LLM to review it or you write with LLM and review it yourself. I don't need some motherfucking autist reviewing my code and nit picking. I write my own open source and proprietary code and I don't need people to review it because most of the time I know best anyway. When I work at a company, I don't want others to create an illusion of being busy and useful by reviewing my PRs. Shrimple as that, nothing personnel.
>>108686596Having said that, I don't get offended because I just don't think PRs are useful and I just know it's all a dance you need to dance to look le professional.
>code review required>pop 'er open>complex sprawling changes that would require actual effort to properly review>eh looks fine, approved
>>108685919GitLab actually agrees with you — they call them merge requests, which describes what actually happens (your code gets merged). Many developers argue this is the more intuitive name since it focuses on the outcome rather than the underlying Git operation.So you're not wrong — "merge request" is arguably clearer. It's just one of those cases where the historically dominant platform's terminology won out over the more descriptive one.
>>108686636Exactly, to properly review someone else code it takes understanding of the underlying part of the system AND the intent behind the change AND understanding of the actual code being reviews. It's possible, but only when I'm the original author of the project who wrote most of it and still knows most of it. When it's a large team where people know separate parts of the project and lack incentive to do these kinds of reviews, it simply doesn't work.
>>108685692Penis Removal
>>108685912My code wasn't bad. It was just short switch statement that executes bunch of short functions. It was handling simple web sockets or something in like 100-200 lines, nothing that necessities OOP. You don't need OOP in JS in webdev at all in 99% of cases anyway. The guy just had that Java mentality where all the logic just be expressed using design patterns, dependency injection, etc.
>>108686596>most of the timeSo you admit that some of the time, some percent, of all the software you ship is fundamentally flawed, defective, inferior, and dangerous because you don't know what you're doing and you should have listened to someone smarter.That's what you JUST said.
I don't open PRs because I think I won't understand wtf they're talking about
>>108686739I don't work on critical software that can become dangerous. If I were, I would definitely be all in favor of mandatory PR reviews. But most programmers, including myself, work on systems that are not critical in any shape or form. Applying the same standards to them is stupid. Also, when I feel like I don't know best, I will specifically ask a more knowledgeable person or maybe just ask the team to spend some time and review my changes. But that almost never happens, because of the nature of the projects I work on. Most PR review culture is just a social dance and cargo culting. Unfortunately I don't think you understand it just yet because of they way you sound.
>>108686636Lmao
>>108686733Just beacuse the if or switch statement isnt visible, does not mean that it isnt there. Oop people LOVE hiding the logic between the classes, nothing clean about it, just r*ssian injection possibilities.
>>108685686If they point out actual good stuff, I listen and improve. Every legitimate criticism I absorb makes me a better programmer.BUT if they point out dumb shit or suggest something stupid, then I'll push back or ignore them.>"We should do [highly unperformant thing] because [performant thing] would take effort to understand.">"Why are we changing [horribly slow thing that barely works and doesn't scale]? What if [1000x faster thing] has bugs we don't know about huh? Let's just leave the existing thing.">"Let's not use [advanced technique that solves our problem] because it's new and unfamiliar to me."Shit like this can get fucked.
>>108687034worst part is, they're proud of hiding ifs that way.
>>108685686Its less about intelligence and more about the ability to regulate your own emotions. Emotional thinking is for women. That's why there are few women in tech. Tech requires logic and reason. That's why tr00ns and their far left friends are every bit as irrational as the far-right. Its all emotional thinking and not a shred of reason to be found.There's also the missing component of being able to communicate with someone in person. When reading text, the reader has to assume all of the nuanced non-verbal parts of communication. So when a person is being gently criticized for doing something retarded they take it as a personal attack and not constructive criticism.You have to remove your emotions when reading text. The "feeling" side of reasoning is really only needed when you're speaking to someone face to face. That's what people mean when they say that they can "read people". Its all about picking up on non-verbal cues. Plaintext does away with that completely so all you have to go on are your own assumptions.>>108685726>define classes for each case and follow recommended OOP design patterns.OOP is brainwashing. Its complete garbage that never solved any problems. But man did entire generations really take the bait. Object capabilities are the best use for OOP but I'm sure that the OOP cultists have no idea.OOP cultists insist that everything be object-oriented all the time but not a single one of them can explain why. Its like trying to get tr00ns and their enablers to explain why a man in a dress is a woman. Not one of them can.
>>108685686i dont put my code on the internet or comment on code put on the internet. i shall not infect my digital domain with baelzebub and moloch-ranting in systemcode for the digital takeover of the human mind and spirit, i am free and they will not capture me.
>>108687090Real world systems need to be scalable. People that deemphasize performance for readability are larpers and not real programmers.I had a tech lead who was like that. He would remove other devs' code, even if they work, mostly for non-technical reasons. Ironically, he wrote non-maintainable and unperformant spaghetti code himself, and the codebase was a mess despite him having the authority to make devs follow good programming practices.
>>108685686no because nobody ever review my pull requests, they just sit in the void for some reasons
